Hydrex AMO deployment#2887
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2887 +/- ##
=======================================
Coverage 42.01% 42.01%
=======================================
Files 111 111
Lines 4874 4874
Branches 1353 1353
=======================================
Hits 2048 2048
Misses 2823 2823
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shahthepro
reviewed
May 6, 2026
Collaborator
shahthepro
left a comment
There was a problem hiding this comment.
Compared the "InitializeGovernedUpgradeabilityProxy" contract with address 0x926846b8fa246B30652B103C369fce5db8B2F593 on base
to local files under folders ".,node_modules"
match @openzeppelin/contracts/utils/Address.sol
match contracts/governance/Governable.sol
match contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
changed contracts/proxies/Proxies.sol
shahthepro
reviewed
May 6, 2026
Collaborator
shahthepro
left a comment
There was a problem hiding this comment.
$ sol2uml diff 0x8daaf5095bb64ad423cfc994b1c3e5291960ff0d .,node_modules --network base --apiKey $ETHERSCAN_API_KEY
Compared the "OETHbHydrexAMOStrategy" contract with address 0x8DAAF5095bb64ad423cfC994b1C3E5291960fF0D on base
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match @openzeppelin/contracts/utils/Address.sol
match @openzeppelin/contracts/utils/math/SafeCast.sol
match @openzeppelin/contracts/utils/math/SafeMath.sol
match contracts/governance/Governable.sol
match contracts/interfaces/algebra/IAlgebraGauge.sol
match contracts/interfaces/algebra/IAlgebraPair.sol
match contracts/interfaces/hydrex/IHydrexGauge.sol
match contracts/interfaces/IBasicToken.sol
match contracts/interfaces/IStrategy.sol
match contracts/interfaces/IVault.sol
match contracts/strategies/algebra/StableSwapAMMStrategy.sol
match contracts/strategies/hydrex/OETHbHydrexAMOStrategy.sol
match contracts/token/OUSD.sol
match contracts/utils/Helpers.sol
match contracts/utils/Initializable.sol
match contracts/utils/InitializableAbstractStrategy.sol
match contracts/utils/PRBMath.sol
match contracts/utils/StableMath.sol
match contracts/vault/VaultStorage.sol
shahthepro
previously approved these changes
May 6, 2026
Collaborator
shahthepro
left a comment
There was a problem hiding this comment.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script. (Someone tried to takeover ownership blindly but those reverted as expected).
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Collaborator
|
clement-ux
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code change PR: #2886
Deployment
Sol2uml
Deploy checklist
Two reviewers complete the following checklist: