Repository navigation
labwc 1:0.20.2-8: a key pressed on the lock screen gets its release too - #13
Merged
Merged
Conversation
Home pressed while the session is locked went to the lock screen, but its release did not: labwc keeps the matched Home binding (on release, not allowed when locked) as the current one, and the release branch then swallows the release. The lock screen kept Home pressed and repeated it until focus moved, which kept an iPad 6 lit and hot for an hour. Upstream labwc master has the same code. Patch 0011 clears the current binding when the press goes to the client, so the release follows it. First written for omarchy-a's own labwc build (0195893, never merged) before labwc moved here. tests/test-locked-key-release.py reads the patched handler: it passes on the patched source and fails on the unpatched one; check() runs it. Assisted-by: LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home pressed while the session is locked went to the lock screen, but
its release did not: labwc keeps the matched Home binding (on release,
not allowed when locked) as the current one, and the release branch then
swallows the release. The lock screen kept Home pressed and repeated it
until focus moved, which kept an iPad 6 lit and hot for an hour. Upstream
labwc master has the same code.
Patch 0011 clears the current binding when the press goes to the client,
so the release follows it. First written for omarchy-a's own labwc build
(0195893, never merged) before labwc moved here.
tests/test-locked-key-release.py reads the patched handler: it passes on
the patched source and fails on the unpatched one; check() runs it.
Assisted-by: LLM
Built locally with ci/build-package (aarch64): every check() test passes, the new one included.