Skip to content

labwc 1:0.20.2-8: a key pressed on the lock screen gets its release too - #13

Merged
henrikklee merged 1 commit into
mainfrom
labwc-lock-key-release
Nov 21, 2026
Merged

henrikklee merged 1 commit into
mainfrom
labwc-lock-key-release

Conversation

@henrikklee

Copy link
Copy Markdown
Contributor

Home pressed while the session is locked went to the lock screen, but
its release did not: labwc keeps the matched Home binding (on release,
not allowed when locked) as the current one, and the release branch then
swallows the release. The lock screen kept Home pressed and repeated it
until focus moved, which kept an iPad 6 lit and hot for an hour. Upstream
labwc master has the same code.

Patch 0011 clears the current binding when the press goes to the client,
so the release follows it. First written for omarchy-a's own labwc build
(0195893, never merged) before labwc moved here.

tests/test-locked-key-release.py reads the patched handler: it passes on
the patched source and fails on the unpatched one; check() runs it.

Assisted-by: LLM

Built locally with ci/build-package (aarch64): every check() test passes, the new one included.

Home pressed while the session is locked went to the lock screen, but
its release did not: labwc keeps the matched Home binding (on release,
not allowed when locked) as the current one, and the release branch then
swallows the release. The lock screen kept Home pressed and repeated it
until focus moved, which kept an iPad 6 lit and hot for an hour. Upstream
labwc master has the same code.

Patch 0011 clears the current binding when the press goes to the client,
so the release follows it. First written for omarchy-a's own labwc build
(0195893, never merged) before labwc moved here.

tests/test-locked-key-release.py reads the patched handler: it passes on
the patched source and fails on the unpatched one; check() runs it.

Assisted-by: LLM
@henrikklee
henrikklee merged commit 1e1040f into main Nov 21, 2026
5 checks passed
@henrikklee
henrikklee deleted the labwc-lock-key-release branch November 21, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant