Repository navigation
labwc: a window card's menu in the overview (0010) - #12
Merged
Merged
Conversation
Patch 0010: a long press on a window's card in the overview (a right click, the Menu key on the selected card) brings up Minimize, Maximize/Restore and Close, the title bar's buttons for a window that has none (maximized windows when title bars are hidden there). A tap beside the menu puts only the menu away; the overview stays open. Minimize and Maximize/Restore leave for the desktop, Close takes the card away as a flick up does. Rows 44 pixels high, in the theme's menu colors. tests/test-overview-menu.py reads the patched overview for how presses, keys and leaving treat the menu; check() runs it. Tried in the simulator (iPad, landscape): a long press on a maximized terminal's card shows Minimize, Restore and Close; a tap beside it puts the menu away and the overview stays; Restore makes the window its own size again with its title bar. Assisted-by: LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
labwc 1:0.20.2-7, patch 0010: a window card's menu in the overview.
A long press on a card (right click, Menu key on the selected card) shows Minimize (not for a minimized window), Maximize/Restore and Close over the overview — the title bar's buttons for maximized windows whose title bar is hidden (omarchy-a's "Title Bars When Maximized"). A tap beside the menu (Escape) closes only the menu; the overview stays. Minimize and Maximize/Restore leave for the desktop; Close removes the card as a flick up does. 44 px rows, theme menu colors. Names are
card_menu_*(labwc has its ownmenu).tests/test-overview-menu.py(run by check()) reads the patched overview for press/key/leave handling. Built locally (aarch64) and tried in the simulator (iPad landscape): long press shows the menu, a tap beside it keeps the overview, Restore makes a maximized terminal floating with its title bar. Not tried: right click, Menu key, Minimize/Close from the menu, phone. Changelog under Unreleased.