Repository navigation
Login session: no direct scan-out on simpledrm with the GPU desktop - #98
Merged
Merged
Conversation
The GPU has no display outputs, so Labwc renders on the GPU and shows its output on the display's card (simpledrm). wlroots still tried to scan out a fullscreen client's GPU buffer directly on that card: AddFB2 failed, the buffer was poisoned, and on the iPod touch 6 the GPU-drawn shell then never appeared. With WLR_SCENE_DISABLE_DIRECT_SCANOUT=1 whenever the display is a separate card, Labwc always composites and the shell shows on the GPU. Tested on an iPod touch 6: shell visible, drawn by Qt Quick on the GPU. Assisted-by: LLM
A display driver that imports the GPU's buffers (on the iPod touch 6, the A8's display pipe scanning out through its display DART) can scan out a client directly, so keep wlroots' direct scan-out there. It stays off when the display card is simpledrm, which takes no dma-buf. Tested on an iPod touch 6 with the A8 display pipe driver: labwc's GPU buffers are imported by the display card and scanned out, and the shell shows. Assisted-by: LLM
Assisted-by: LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the GPU desktop, Labwc renders on the GPU (which has no display outputs) and shows the result on the display's own card. When that card is simpledrm, wlroots still tried to scan out a fullscreen client's GPU buffer directly on it: AddFB2 failed with EINVAL, the buffer was poisoned, and on the iPod touch 6 the shell drawn on the GPU never appeared. The software shell was fine because shm buffers never take that path.
The session now adds
WLR_SCENE_DISABLE_DIRECT_SCANOUT=1to the GPU desktop's environment only when the display card's driver is simpledrm, which takes no dma-buf. A display driver that imports the GPU's buffers keeps direct scan-out. Boards without a GPU, and the software desktop, are unchanged.Tested on an iPod touch 6:
🤖 Generated with Claude Code