Highlight changed Solidity code lines#811
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesChanged-line highlighting
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Thanks for the PR. There's an issue with spacing, as sometimes empty lines are inserted between every line. But overall I think this should take a different approach in terms of design. Currently the highlights remain visible long after making changes to the selected option, and it's not clear to the user what the highlights mean. Yellow particularly looks like a warning and users may mistaken the highlights as code issues. Instead, perhaps one of the following would work better, using a combination of transitions and timing:
But in any case, the steady state (e.g. after a few hundred milliseconds) there should be no long-term highlights visible in the code. Curious to get your thoughts on the above and whether you would like to make those changes. |
Refs #219.
This draft PR adds a lightweight visual highlight for Solidity code lines that change after feature toggles.
Notes:
Validation: