Repository navigation
ci(release): gate only the publish on approval - #201
Conversation
A release asked for compact-npm-prod approval twice: once to open the release PR and again to publish. The prepare job needs no environment secret, and its PR still waits on checks and code-owner review, so the publish gate is the only one kept.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe release job no longer targets the ChangesRelease approval and publication
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~7 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to Release preparation proceeds without the production approval request, while tagging and npm publication remain behind the compact-npm-prod workflow gate. The available evidence does not establish an unapproved publishing path. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the release trail Comment |
Types of changes
What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an
xin the boxes that applyA release asked for
compact-npm-prodapproval twice: once in "Release Package" before opening the release PR, and again in "Publish Release" before npm. This keeps only the publish gate.Not visible in the diff:
vars.GH_APP_ID,secrets.GH_APP_PRIVATE_KEY). The environment holds justNPM_TOKEN, which only the publish job uses, so dropping the environment there loses no secret.PR Checklist
Summary by CodeRabbit