Repository navigation
refactor(compact-lint): read the [lint] table of compact.toml - #190
Merged
0xisk merged 1 commit intoSep 15, 2026
Merged
Conversation
One project, one config file. compact-deploy already owns `compact.toml`, so the linter moves its settings under a `[lint]` table there and `compact-lint.toml` goes away before anything ships. * The linter parses the whole document but deserialises only `lint`; every other table is another tool's and is ignored. A file with no `[lint]` table is a config error, no file at all keeps the built-in defaults. * The `version` key is dropped: tables are namespaced per tool and the deployer's file has none either. * A deployer test pins that its loader strips the `[lint]` table, so the two tools keep sharing the file without a schema change.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Member
Author
|
Folded into #189 as its second commit ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Depends on #189, merge after.
compact-deployandcompact-linteach read a project TOML. This makes it one file,compact.toml, with the linter under[lint]and the deployer's tables untouched.Not visible in the diff:
.strict(), so it already drops a[lint]table. The new deployer test exists to keep that true.deny_unknown_fieldsat the root and keeps it inside[lint], so a typo under the linter's own table is still rejected while foreign tables pass.version = 1is gone. Nothing shipped with it, and the deployer's half of the file has no version key.git mvand were rewritten by script; noexpected*.txtchanged, which is the proof the rename is behaviour-neutral.compactCLI ever claimscompact.toml,[lint]survives as a namespace. The deployer's bare[networks]/[contracts]tables would not, and moving them is a separate decision.Start with
crates/compact-lint/src/config.rs(Documentwrapper,MissingLintTable).PR Checklist