Repository navigation
build(contracts): bump compact-deployer to 0.3.1 - #998
Conversation
0.3.1 inserts each verifier key under the version the ledger accepts for it. The multisig zkir-v3 build emits `[v7]` keys, which 0.3.0 inserted as `v3`, failing every NativeShieldedTokenIssuer deploy. Closes #997
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe development dependency requirement for ChangesCompact deployer update
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established in the dependency update. The reported live tests remain a useful follow-up, but their absence alone does not indicate a failure. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the version line, Comment |
Types of changes
What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an
xin the boxes that applyFixes #997
compact-deployer 0.3.1 (OpenZeppelin/compact-tools#200) inserts each verifier key under the version the ledger accepts for it. 0.3.0 inserted every key as
v3, so the zkir-v3 multisig build's[v7]keys failed the follow-up insert of everyNativeShieldedTokenIssuerdeploy.The lockfile keeps a single
@midnightntwrk/ledger-v9(1.0.0-rc.5).PR Checklist
Further comments
Not yet run live. The check is
NativeShieldedTokenIssuer.test.tsandNativeShieldedTokenIssuerExample.test.tsundertest:live multisig.Summary by CodeRabbit