Skip to content

build(contracts): bump compact-deployer to 0.3.1 - #998

Merged
0xisk merged 1 commit into
mainfrom
fix/issuer-deployer-vk-version
Sep 25, 2026
Merged

0xisk merged 1 commit into
mainfrom
fix/issuer-deployer-vk-version

Conversation

@0xisk

@0xisk 0xisk commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Fixes #997

compact-deployer 0.3.1 (OpenZeppelin/compact-tools#200) inserts each verifier key under the version the ledger accepts for it. 0.3.0 inserted every key as v3, so the zkir-v3 multisig build's [v7] keys failed the follow-up insert of every NativeShieldedTokenIssuer deploy.

The lockfile keeps a single @midnightntwrk/ledger-v9 (1.0.0-rc.5).

PR Checklist

Further comments

Not yet run live. The check is NativeShieldedTokenIssuer.test.ts and NativeShieldedTokenIssuerExample.test.ts under test:live multisig.

Summary by CodeRabbit

  • Chores
    • Made a small internal maintenance update. There are no changes to user-facing features or behavior in this release, and no action is needed. Existing functionality remains unchanged.

0.3.1 inserts each verifier key under the version the ledger accepts
for it. The multisig zkir-v3 build emits `[v7]` keys, which 0.3.0
inserted as `v3`, failing every NativeShieldedTokenIssuer deploy.

Closes #997
@0xisk
0xisk requested review from a team as code owners September 25, 2026 09:16
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: df12b589-4235-4b1c-b21f-6fcfe86667fb

📥 Commits

Reviewing files that changed from the base of the PR and between e244dfc and 46dd75c.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • contracts/package.json

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The development dependency requirement for @openzeppelin/compact-deployer changes from ^0.3.0 to ^0.3.1.

Changes

Compact deployer update

Layer / File(s) Summary
Update compact-deployer requirement
contracts/package.json
The @openzeppelin/compact-deployer development dependency requirement changes from ^0.3.0 to ^0.3.1.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: andrew-fleming

Merge Risk: ⚪ Minimal · up to 46dd7

No actionable merge-blocking issue is established in the dependency update. The reported live tests remain a useful follow-up, but their absence alone does not indicate a failure.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the @openzeppelin/compact-deployer dependency to version 0.3.1.
Linked Issues check ✅ Passed No active directly linked issues remain. Issue #997 is closed and supplies historical context only. Therefore, this pull request has no active linked-issue coding requirements. The change updates `@op…
Out of Scope Changes check ✅ Passed The pull request changes only contracts/package.json. The dependency update to @openzeppelin/compact-deployer ^0.3.1 matches the stated purpose. No unrelated changes are present in the reviewed …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the version line,
A newer deployer joins the file.
The package notes the change in place,
While carrots wait beside the case.
Soft paws hop through review with care.

Comment @coderabbitai help to get the list of available commands.

@0xisk
0xisk merged commit 7600ba8 into main Sep 25, 2026
9 checks passed
@0xisk
0xisk deleted the fix/issuer-deployer-vk-version branch September 25, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: NativeShieldedTokenIssuer specs fail the fragmented deploy on live

2 participants