[0xisk]

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Refs #727. #1183 stacks on this: its delivery pads become UintN<248>.

Draft until the test suite lands.

Not visible in the diff:

• The category wiring (compile:math, its turbo task, the live-math pair) is build(math): add the math category scaffold (1/13) #1125's hunks verbatim, so the math stack rebases onto this as a no-op.
• wrappingAdd tests a > MAX - b, with MAX cast from the constant MODULUS() - 1. Casting MODULUS() - 1 - b costs one more 248-bit range check (1126 vs 980 rows at 248). This form matches the pinned pad in feat(token): add confidential note delivery extension #1183 instruction for instruction.
• MODULUS folds to a constant at every width, so the generic body costs nothing over a literal.

PR Checklist

• I have read the Contributing Guide
• I have added tests that prove my fix is effective or that my feature works. See GUIDELINES.md#testing for more information.
• I have added documentation for new methods or changes to existing method behavior. See GUIDELINES.md#documentation for more information.
• CI Workflows Are Passing

Further comments

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}