Repository navigation
fix: support escaped dots and backslashes in required field paths - #46
Merged
AdityaWagh06 merged 1 commit intoNov 7, 2026
Merged
Conversation
AdityaWagh06
approved these changes
Nov 7, 2026
AdityaWagh06
added a commit
that referenced
this pull request
Nov 7, 2026
AdityaWagh06
added a commit
that referenced
this pull request
Nov 7, 2026
Member
|
Thanks @Mrun25, clean fix with great tests, merged! 🎉 That's your 4th merged PR in ModelDiff. If you like the project, a ⭐ on the repo helps a lot. Follow OpenWave India for new issues and releases: |
Contributor
Author
|
Thanks for the review and kind words! Glad I could contribute 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Closes #31
Split required-field paths without treating escaped dots as separators.
\.addresses a literal dot and\\addresses a literal backslash; other backslashes, including a trailing one, remain literal. Bothrequiredandvaluesuse this lookup, list indexes keep working, and failure reasons keep the original path spelling.Document the escape syntax and YAML/JSON quoting in README and docs/file-formats.md. No new dependencies.
How it was tested
ruff check src tests examplesandruff format --check src tests examplespass.Checklist
pytestpasses locallyruff checkandruff format --checkpass