Repository navigation
fix(checks): list allowed classification labels - #44
Merged
AdityaWagh06 merged 1 commit intoOct 31, 2026
Merged
AdityaWagh06 merged 1 commit into
AdityaWagh06 merged 1 commit into
Conversation
There was a problem hiding this comment.
Thanks for your first pull request to ModelDiff! A maintainer will review it soon. CI for first-time contributors starts after a maintainer approves it.
While you wait, please check that:
- The issue was assigned to you before you started (see One issue at a time).
- The description links the issue (
Closes #12) and says how you tested the change. pytest,ruff check src tests examplesandruff format --check src tests examplespass locally.- The Files changed tab shows only changes for this issue.
Member
|
Merged, thank you @awais-ur-rehman, and congrats on your first contribution to ModelDiff! 🎉 The message matches the issue exactly, and the tests cover the cap, normalization and the unchanged details. Clean work. It’ll ship in v0.2.0 next week. If you enjoyed contributing, a ⭐ on the repo helps others find the project. Follow OpenWave India on GitHub and LinkedIn for new projects coming soon. |
AdityaWagh06
added a commit
that referenced
this pull request
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Classification failures now list the allowed labels in suite order, using the existing normalization setting and showing at most ten entries. The result details and pass/fail rules stay the same.
Closes #40. Related: #35, which was closed so this issue could be assigned to a first-time contributor.
How it was tested
python -m pytest: 181 passed.ruff check src tests examples: All checks passed!ruff format --check src tests examples: 21 files already formatted.git diff --check: clean.Checklist
pytestpasses locallyruff checkandruff format --checkpassOpenAI Codex assisted with implementation and test execution.