Repository navigation
fix(directory): presentCredential offers only credentials your agent presents as the member - #376
Merged
Merged
Conversation
…presents as the member The community accepts a verified field only from a presentation its member holds, so a credential bound to another key (an SD-JWT with a separate holder did:key) was offered, chosen, presented and then refused. The wallet now asks the agent only for credentials whose subject is the member's DID (vault/credentials/query subjectDid, trust-tasks-tf #884). Needs a VTA that serves subjectDid: an older one refuses the query as malformed, so this ships after the VTI release that carries it. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The community accepts a verified field only from a presentation its member holds, so a credential bound to another key (an SD-JWT with a separate holder did:key) was offered, chosen, presented and then refused. The wallet now asks the agent only for credentials whose subject is the member's DID (vault/credentials/query subjectDid, trust-tasks-tf #884).
Needs a VTA that serves subjectDid: an older one refuses the query as malformed, so this ships after the VTI release that carries it.
Draft until trustoverip/dtgwg-trust-tasks-tf#884 merges and a VTI release serves
subjectDid(VTI PR to follow). No@openvtc/trust-tasksbump needed to build; the core test checks the payload carries the filter and that it alone is refused before sending.