Repository navigation
Conversation
openvtc-core generates its spec types with trust-tasks-build from pinned, vendored bundles (trust-tasks.toml/.lock) instead of trust-tasks-rs's deprecated prebuilt modules; trust-tasks-rs 0.35 is the runtime only. Every task is sent at its latest version. Tasks whose version differs from vta-sdk's typed client go through openvtc_core::vta_task::call. The join manifest 0.3/0.2 + submit 0.2 fallback and the key-package 0.1 fallback are removed: the VTI stack moves to the current versions. Builds once VTI releases vta-sdk/vta-service/vti-vetting-pcs on trust-tasks 0.35. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openvtc-core/build.rsrunstrust-tasks-build0.1.2 overopenvtc-core/trust-tasks.toml/trust-tasks.lockand the vendored bundles inopenvtc-core/trust-tasks/, producingopenvtc_core::specs.trust-tasks-rs0.35.3 is used as the runtime only (default-features = false); the deprecated prebuilttrust_tasks_rs::specsmodules are no longer used.trust-tasks checkpasses on the 41 pins.manifest/0.4,submit/0.3),vta/witness/list/0.2,vtc/rooms/offers/list/0.4, git-nsview/0.6/drift/resolve/0.4/repo/create/0.4/right/{grant,revoke}/0.4,persona/profile/compose/1.1,persona/attribute/promote/1.1andvtc/vetting/vetters/resend/0.2.openvtc_core::vta_task::callsends a generated payload throughVtaClient::dispatch_trust_task. It's used where vta-sdk's typed method is pinned to an older version (witness, persona).manifest/0.3/0.2+submit/0.2, and room key-package 0.1. The VTI stack (VTA/VTC) is moving to the latest versions. A pending join saved by an earlier build still loads (v0_3/v0_2read as 0.4).affinidi-tdk0.33,affinidi-messaging-sdk0.41, test mediator 0.46,didwebvh-rs0.8.2.This branch does not build from crates.io yet.
vta-sdk0.73 is still on trust-tasks 0.34, so the dependency graph splits. It needs:vta-sdk/vta-service/vti-vetting-pcsreleased on trust-tasks 0.35. If VTI lands on different tdk / messaging-sdk lines, the pins here follow.MockVtamust servevta/witness/list/0.2forwitness_e2e::a_lost_witnessing_is_rebuilt_from_the_vtas_list.vetting::protocol::Manifestand its scoped#[allow(deprecated)]follow.Test plan
Run against the VTI
chore/trust-tasks-rs-0.35worktree, patched in through--configonly. The committedCargo.lockresolves from crates.io.cargo clippy --all-targets --all-features -D warnings(workspace +dev-overrides)cargo docwith-D warnings,cargo fmt --checkcargo test --workspace -- --include-ignored: 2183 pass, 1 fails (a_lost_witnessing_is_rebuilt_from_the_vtas_list, MockVta lacks witness/list 0.2)Pre-merge checklist (vti-stack-development-guide)
vta_task::callsites pass explicit 30s timeoutsnext_cursor