Repository navigation
fix(join): Esc stops waiting for a community's challenge; release 0.5.0 - #443
Merged
Merged
Conversation
While a hidden-vetting join waits for the community's challenge (up to 15 seconds), the progress page locked every key but F10. Nothing has been sent at that point, so leaving costs nothing; the page now takes Esc, says so in its message and its footer, and the loop holding the wait forgets the query and returns to the main page with a log line saying nothing was sent. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
Bump the workspace to 0.5.0 (a minor bump: openvtc-core's JoinPresentation gained a field), update the intra-workspace version requirements, and move Unreleased to [0.5.0] - 2026-10-05 with a summary and entries for the vetting journeys, join review, trust-registry consent, PQC / PCS ZKP badges, decline reasons, the self-fetching PCS challenge, and the fixes. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits:
1. fix(join): Esc stops waiting for a community's challenge
While a hidden-vetting (PCS ZKP) join waited up to 15 seconds for the community's challenge (#442), the progress page locked every key except F10. Nothing has been sent at that point, so leaving should cost nothing.
JoinState::waiting_on_challengeis set when the join parks. It's cleared when the parked join resumes (run, any entry) or is cancelled.JoinCancel. The footer shows[ESC] stop waiting — nothing is sent, and the waiting message says it gives up after 15 seconds and that Esc stops the wait.esc_leaves_a_wait_for_the_challenge_and_only_that.2. chore: release 0.5.0
0.5.0. It's a minor bump becauseopenvtc-core'sJoinPresentationgained a field (feat: an applicant can consent to trust-registry publication when joining #439).openvtc-core = "0.5"andopenvtc-vetting-pcs = "0.5.0", following the 0.4.0 release (chore: release 0.4.0 #424).Unreleasedbecomes[0.5.0] - 2026-10-05, with a summary, major changes, and entries for fix(join): the cursor can reach Send an open request #428–feat(join): a hidden-vetting join asks the community for its challenge itself #442 and this fix. Most of those PRs hadn't added entries.Checks
All pass, run as CI does:
cargo fmt --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacecargo test --workspace --no-default-featuresRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps