Skip to content

fix: stabilize atmosphere-derived features across pandas versions - #1144

Merged
egordm merged 2 commits into
mainfrom
fix/STEF-2956-atmosphere-derived-units
Oct 15, 2026
Merged

egordm merged 2 commits into
mainfrom
fix/STEF-2956-atmosphere-derived-units

Conversation

@egordm

@egordm egordm commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Makes atmosphere-derived feature calculations independent of pandas in-place mutation behavior. Relative humidity is converted from percent to a fraction for vapour pressure; humidity and pressure conversions stay local so input columns are not mutated. Air density uses pressure converted from hPa to Pa.

This corrects derived feature values. Retrain models that use these features after deployment.

Type of change

  • Bug fix
  • New feature
  • Breaking change (see checklist below)
  • Documentation
  • Refactor / chore / CI

AI disclosure

  • No AI assistance was used (beyond grammar/spelling)
  • AI assistance was used - tool(s): GitHub Copilot
    • I have reviewed, understand, and can explain all AI-generated code in this PR
    • This is disclosed in a commit message

Checklist

  • poe all --check passes locally
  • Tests added/updated for the change
  • Documentation updated if needed
  • Commit signed off per DCO
  • PR title follows Conventional Commits

Validation

  • 8 atmosphere-transform tests passed under pandas 2 and pandas 3
  • 31 weather-domain tests passed
  • Ruff and ty passed

Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
@egordm
egordm requested a review from a team October 15, 2026 08:23
@github-actions github-actions Bot added the fix Something isn't working label Oct 15, 2026
@sonarqubecloud

Copy link
Copy Markdown

@egordm
egordm merged commit ca71689 into main Oct 15, 2026
6 checks passed
@egordm
egordm deleted the fix/STEF-2956-atmosphere-derived-units branch October 15, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants