Repository navigation
fix: resolve sklearn quality gate warnings - #1136
Merged
egordm merged 2 commits intoOct 12, 2026
Merged
Conversation
Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com> Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
egordm
added this pull request to stack #1137
October 12, 2026 08:04
Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com> Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
|
lschilders
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What does this PR do?
Resolves scikit-learn warning failures that prevented the full local quality gate from passing:
penalty="l2"; non-default penalties remain configurable without duplicating constructor setup.This PR is stacked on #1135 and should be merged after it.
No linked issue.
Validation:
uv run poe all --checkpasses locally. The focused splitter/doctest/logistic checks also pass (7 tests).Type of change
Breaking changes checklist
_migrate_statemigration patternMigration path for existing users: N/A.
AI disclosure
Assisted-by: <tool name>)Checklist
poe all --checkpasses locallygit commit -s)feat: ...,fix: ...,feat!: ...for breaking changes)