Skip to content

Perbaikan penanganan error validasi pada form create dan edit master bantuan #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
habibie11 wants to merge 1 commit into
base: rilis-dev
Choose a base branch
from
Open

Perbaikan penanganan error validasi pada form create dan edit master bantuan #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 59 additions & 10 deletions resources/views/master/bantuan/create.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,63 @@ class="fas fa-times"></i>&nbsp; Batal</button>
width: '100%'
});

function showErrorAlert(response, fallbackMessage) {
let data = response;
if (typeof data === 'string') {
try {
data = JSON.parse(data);
} catch (e) {
data = null;
}
}

let errorList = [];
if (data && data.errors) {
if (Array.isArray(data.errors)) {
errorList = data.errors;
} else if (typeof data.errors === 'object') {
Object.values(data.errors).forEach(function(err) {
if (Array.isArray(err)) {
errorList.push(...err);
} else if (typeof err === 'string') {
errorList.push(err);
}
});
} else if (typeof data.errors === 'string') {
errorList.push(data.errors);
}
}

if (errorList.length > 1) {
let escapeHtml = function(text) {
let div = document.createElement('div');
div.textContent = text;
return div.innerHTML;
};
Swal.fire({
title: 'Error!',
html: '<ul style="text-align: left; margin: 0; padding-left: 20px;">' +
errorList.map(function(err) {
return '<li>' + escapeHtml(err) + '</li>';
}).join('') + '</ul>',
icon: 'error'
});
} else if (errorList.length === 1) {
Swal.fire({
title: 'Error!',
text: errorList[0],
icon: 'error'
});
} else {
let message = (data && data.message) ? data.message : (fallbackMessage || 'Terjadi kesalahan sistem');
Swal.fire({
title: 'Error!',
text: message,
icon: 'error'
});
}
}

$(document).on('click', 'button#submit', function(e) {
e.preventDefault();
let dateParam = $.param({
Expand Down Expand Up @@ -204,19 +261,11 @@ class="fas fa-times"></i>&nbsp; Batal</button>
})
window.location = `{{ url('master/bantuan') }}`
} else {
Swal.fire(
'Error!',
response.message,
'error'
)
showErrorAlert(response);
}
},
error: function(xhr, ajaxOptions, thrownError) {
Swal.fire(
'Error!',
xhr.responseJSON.message,
'error'
)
showErrorAlert(xhr.responseJSON || xhr.responseText, thrownError);
}
});
}
Expand Down
61 changes: 59 additions & 2 deletions resources/views/master/bantuan/edit.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,63 @@ class="fas fa-times"></i>&nbsp; Batal</button>
})
.catch(error => console.error('Error saat mengambil data:', error));

function showErrorAlert(response, fallbackMessage) {
let data = response;
if (typeof data === 'string') {
try {
data = JSON.parse(data);
} catch (e) {
data = null;
}
}

let errorList = [];
if (data && data.errors) {
if (Array.isArray(data.errors)) {
errorList = data.errors;
} else if (typeof data.errors === 'object') {
Object.values(data.errors).forEach(function(err) {
if (Array.isArray(err)) {
errorList.push(...err);
} else if (typeof err === 'string') {
errorList.push(err);
}
});
} else if (typeof data.errors === 'string') {
errorList.push(data.errors);
}
}

if (errorList.length > 1) {
let escapeHtml = function(text) {
let div = document.createElement('div');
div.textContent = text;
return div.innerHTML;
};
Swal.fire({
title: 'Error!',
html: '<ul style="text-align: left; margin: 0; padding-left: 20px;">' +
errorList.map(function(err) {
return '<li>' + escapeHtml(err) + '</li>';
}).join('') + '</ul>',
icon: 'error'
});
} else if (errorList.length === 1) {
Swal.fire({
title: 'Error!',
text: errorList[0],
icon: 'error'
});
} else {
let message = (data && data.message) ? data.message : (fallbackMessage || 'Terjadi kesalahan sistem');
Swal.fire({
title: 'Error!',
text: message,
icon: 'error'
});
}
}

$(document).on('click', 'button#submit', function(e) {
e.preventDefault();
let dateParam = $.param({
Expand Down Expand Up @@ -239,11 +296,11 @@ class="fas fa-times"></i>&nbsp; Batal</button>
})
window.location = `{{ url('master/bantuan') }}?clear_cache=${id}`
} else {
Swal.fire('Error!', response.message, 'error')
showErrorAlert(response);
}
},
error: function(xhr, ajaxOptions, thrownError) {
Swal.fire('Error!', xhr.responseJSON.message, 'error')
showErrorAlert(xhr.responseJSON || xhr.responseText, thrownError);
}
});
}
Expand Down
31 changes: 31 additions & 0 deletions tests/Feature/MasterBantuanKabupatenTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php

namespace Tests\Feature;

use PHPUnit\Framework\Attributes\Test;
use Tests\BaseTestCase;

class MasterBantuanKabupatenTest extends BaseTestCase
{
#[Test]
public function it_can_access_bantuan_create_and_contains_show_error_alert()
{
$response = $this->get(route('bantuan.create'));
$response->assertStatus(200);
$response->assertViewIs('master.bantuan.create');
$response->assertSee('showErrorAlert', false);
$response->assertSee('data.errors', false);
}

#[Test]
public function it_can_access_bantuan_edit_and_contains_show_error_alert()
{
$bantuanId = 1;
$response = $this->get(route('bantuan.edit', ['bantuan' => $bantuanId]));
$response->assertStatus(200);
$response->assertViewIs('master.bantuan.edit');
$response->assertViewHas('id', $bantuanId);
$response->assertSee('showErrorAlert', false);
$response->assertSee('data.errors', false);
}
}
Loading