Fix whitespace in statistics detail link parameters - #1286
Open
pandigresik wants to merge 1 commit into
Open
pandigresik wants to merge 1 commit into
pandigresik wants to merge 1 commit into
Conversation
|
🔄 AI PR Review sedang antri di server...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix masalah whitespace pada teks kategori statistik penduduk yang digunakan sebagai parameter URL di halaman detail statistik. Perubahan ini menambahkan
.trim()pada extracted text dari DOM element.pilih-kategori > a.activeuntuk memastikan tidak ada karakter whitespace yang tidak diinginkan ikut terkirim ke API.Catatan penting: Domain OpenKab harus sudah didaftarkan pada API Database Gabungan agar tidak terkena masalah CORS.
Changes made:
.trim()pada$('.pilih-kategori > a.active').text()di 4 lokasi padaresources/views/statistik/index.blade.phpuntuk membersihkan whitespace dari teks kategori aktifjudul(judul detail statistik)tipe(tipe kategori statistik)Reason for change:
Impact of change:
juduldantipeakan memiliki value yang bersih tanpa whitespaceRelated Issue
Steps to Reproduce
Before fix (problem):
After fix (solution):
Checklist
Technical Details
Technical Explanation
Perubahan dilakukan pada file
resources/views/statistik/index.blade.phpdi 4 lokasi yang menangani pembuatan link detail statistik penduduk. Setiap lokasi menggunakan$('.pilih-kategori > a.active').text()untuk mendapatkan teks kategori aktif, dan perubahan menambahkan.trim()untuk memastikan teks tersebut bersih dari whitespace.Configuration changes
Dependencies added
Testing
Manual Testing
Screenshots / Video
Before:
Tidak ada screenshot - perubahan minimal pada parameter URL
After:
Tidak ada screenshot - perubahan minimal pada parameter URL
Breaking Changes
None
Migration Guide
Not required
References
Additional notes: Pastikan domain OpenKab sudah terdaftar pada API Database Gabungan untuk menghindari masalah CORS. Perubahan ini hanya membersihkan whitespace pada parameter URL dan tidak mempengaruhi fungsi utama halaman statistik.