Repository navigation
fix: the map's names and routes, and long text in the panels - #33
Merged
Merged
Conversation
…issions Real missions showed three flaws of v0.2.0. With nothing on the map selected, the inspector falls back to the record under the hidden source's cursor, often a trigger, and every route faded. Names could land under the legend, the scale, the axes' note, the player's start note or the selection's place note. And in the Threads and Breakpoints tables, a long cell ran into the next column, such as a thread's "line 3159 · offset 3191". Routes now fade only when the selection is on one. The notes' places are taken before the names are placed. A table's cells are cut with an ellipsis at their column, and a thread's offset shows only where its column has room.
…elpers A review pass over the pull request and the code around it. Find cut its lines at 60 bytes, which could split a character, and a long name in Variables ran into its value: both are now cut at their width with an ellipsis. The ellipsis search halves the length instead of trying each one, so long lines stay cheap. The empty inspector's, reference's and live scene's messages ran past the panel's edge at the default window size, and now wrap. The rest shares code: one place for the flight groups' colours, the player's colour and a trigger's on(...) form, a named font size for tags and the map's notes, and named margins and paddings that the map's notes use both to measure and to draw. The map draws the same pixels as before.
vdmkenny
pushed a commit
that referenced
this pull request
Oct 15, 2026
🤖 I have created a release *beep* *boop* --- ## [0.2.1](v0.2.0...v0.2.1) (2026-10-15) ### Fixes * panel tabs stay inside their bar in narrow windows ([#36](#36)) ([74125a9](74125a9)) * the map's names and routes, and long text in the panels ([#33](#33)) ([dc1f6e3](dc1f6e3)) * the map's toolbar fits narrow windows ([#35](#35)) ([7ea8701](7ea8701)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaws of v0.2.0 that real missions showed, found while taking screenshots of mission 6, and a few more found in a review of the code around them:
line 3159 · offset 3191overlapped the next column. Cells are now cut with an ellipsis at their column, and a thread's offset shows only where its column has room.The review also shares code: one place for the flight groups' colours, the player's colour and a trigger's
on(...)form, a named font size for tags and the map's notes, and named margins and paddings that the map's notes use both to measure and to draw. The ellipsis search halves the length instead of trying each one.Checked on mission 6 headless, where the map draws the same pixels before and after the review's changes, and with the Threads table linked to OpenReliant, held at a breakpoint.