Skip to content

fix: the map's names and routes, and long text in the panels - #33

Merged
vdmkenny merged 2 commits into
mainfrom
fix/map-and-threads-in-busy-missions
Oct 15, 2026
Merged

vdmkenny merged 2 commits into
mainfrom
fix/map-and-threads-in-busy-missions

Conversation

@vdmkenny

@vdmkenny vdmkenny commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Flaws of v0.2.0 that real missions showed, found while taking screenshots of mission 6, and a few more found in a review of the code around them:

  • Routes faded for no reason. With nothing on the map selected, the inspector falls back to the record under the hidden source's cursor, often a trigger, and every route faded. Routes now fade only when the selection is on one.
  • Names under the map's notes. A name could land under the legend, the scale, the axes' note, the player's start note or the selection's place note and brackets. Their places are now taken before the names are placed.
  • Table cells ran into the next column. In Threads and Breakpoints, long text such as a thread's line 3159 · offset 3191 overlapped the next column. Cells are now cut with an ellipsis at their column, and a thread's offset shows only where its column has room.
  • Long text in other panels. Find cut its lines at 60 bytes, which could split a character, and a long name in Variables ran into its value. Both are now cut at their width with an ellipsis. The empty inspector's, reference's and live scene's messages ran past the panel's edge at the default window size, and now wrap.

The review also shares code: one place for the flight groups' colours, the player's colour and a trigger's on(...) form, a named font size for tags and the map's notes, and named margins and paddings that the map's notes use both to measure and to draw. The ellipsis search halves the length instead of trying each one.

Checked on mission 6 headless, where the map draws the same pixels before and after the review's changes, and with the Threads table linked to OpenReliant, held at a breakpoint.

…issions

Real missions showed three flaws of v0.2.0. With nothing on the map selected,
the inspector falls back to the record under the hidden source's cursor, often
a trigger, and every route faded. Names could land under the legend, the
scale, the axes' note, the player's start note or the selection's place note.
And in the Threads and Breakpoints tables, a long cell ran into the next
column, such as a thread's "line 3159 · offset 3191".

Routes now fade only when the selection is on one. The notes' places are taken
before the names are placed. A table's cells are cut with an ellipsis at their
column, and a thread's offset shows only where its column has room.
…elpers

A review pass over the pull request and the code around it.

Find cut its lines at 60 bytes, which could split a character, and a long name in Variables ran
into its value: both are now cut at their width with an ellipsis. The ellipsis search halves the
length instead of trying each one, so long lines stay cheap. The empty inspector's, reference's
and live scene's messages ran past the panel's edge at the default window size, and now wrap.

The rest shares code: one place for the flight groups' colours, the player's colour and a
trigger's on(...) form, a named font size for tags and the map's notes, and named margins and
paddings that the map's notes use both to measure and to draw. The map draws the same pixels as
before.
@vdmkenny vdmkenny changed the title fix: the map's names and routes, and the debugger's tables, in busy missions fix: the map's names and routes, and long text in the panels Oct 15, 2026
@vdmkenny
vdmkenny merged commit dc1f6e3 into main Oct 15, 2026
3 checks passed
@vdmkenny
vdmkenny deleted the fix/map-and-threads-in-busy-missions branch October 15, 2026 20:38
vdmkenny pushed a commit that referenced this pull request Oct 15, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](v0.2.0...v0.2.1)
(2026-10-15)


### Fixes

* panel tabs stay inside their bar in narrow windows
([#36](#36))
([74125a9](74125a9))
* the map's names and routes, and long text in the panels
([#33](#33))
([dc1f6e3](dc1f6e3))
* the map's toolbar fits narrow windows
([#35](#35))
([7ea8701](7ea8701))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant