Repository navigation
Revert filament_diameter and min_nozzle_diameter to mm - #154
Merged
Merged
Conversation
Restore keys 30 (filament_diameter) and 33 (min_nozzle_diameter) as number in mm. Mark keys 61 and 62 (the former _v2 µm fields) as deprecated so they are never reused.
ljanecek
force-pushed
the
revert-diameter-v2
branch
from
September 25, 2026 10:51
ab7b095 to
933f6a1
Compare
ondratu
previously approved these changes
Sep 25, 2026
CZDanol
reviewed
Sep 25, 2026
| ## Not yet released | ||
| 1. `filament_diameter` (mm) replaced with `filament_diameter_v2` (µm) to align with the OpenPrintTag architecture | ||
| 1. `min_nozzle_diameter` (mm) replaced with `min_nozzle_diameter_v2` (µm) to align with the OpenPrintTag architecture | ||
| 1. `filament_diameter_v2` and `min_nozzle_diameter_v2` (µm) removed, `filament_diameter` and `min_nozzle_diameter` (mm) restored |
Collaborator
There was a problem hiding this comment.
You've removed the "filament_diameter_ removal info, so "restored" does not make much sense now.
The entry said the mm fields were restored, but their removal is no longer listed, so it read as undoing a change that is not in the changelog.
CZDanol
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore keys 30 (
filament_diameter) and 33 (min_nozzle_diameter) asnumberin mm. Mark keys 61 and 62 (the former_v2µm fields) as deprecated so they are never reused.This reverts the field changes from #149 (04ddc46). The
_v2fields were published in the spec docs, so the changelog now records their removal.Also fixes the TPU default in
material_type_enum.yaml, which used the oldmin_nozzle_diametername with a µm value (400→0.4).