Skip to content

Skip UUID derivation check for packages without GTIN #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondratu merged 1 commit into from
Oct 14, 2026
Merged

Skip UUID derivation check for packages without GTIN #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/validate_json_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,15 @@ def validate_uuids(self) -> None:
# FK validation will catch missing brand
continue

# UUID is derived from GTIN; without GTIN (not required by the schema)
# the UUID can't be verified - it may be provided by the manufacturer.
gtin = package_data.get('gtin')
if gtin is None or 'uuid' not in package_data:
continue

try:
brand_uuid = uuid.UUID(brand_data['uuid'])
expected_uuid = generate_material_package_uuid(brand_uuid, package_data['gtin'])
expected_uuid = generate_material_package_uuid(brand_uuid, gtin)
is_valid = expected_uuid == uuid.UUID(package_data['uuid'])
if not is_valid:
self.errors.append(ValidationError(
Expand Down
Loading