Conversation
The FD side of UpdateSecurityRevision (0x22) needs a callback to raise the security revision floor of the active running image. It is a required method, like get_non_functional_component_info (#24): a default that answered "revision committed" would tell the UA the floor moved while the old image stayed installable. The typed `SecurityRevisionTarget` and `SecurityRevisionResult` live next to the message in pldm-common. The target decodes the 0xFFFF classification once, so an implementor never re-reads the raw fields to tell a component from one or all downstream devices. Assisted-by: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #22 added the UpdateSecurityRevision (0x22) message layer. This adds the
callback the firmware device needs to act on it. The dispatch and responder
that call it are the next PR, based on this branch.
FdOps::update_security_revision(target, fw_params)takes a decodedSecurityRevisionTargetand answersUpdatedorNotPermitted. The targetdecodes the 0xFFFF classification once, so an implementor never re-reads the
raw fields to tell a component from one or all downstream devices.
The method is required, no default, like
get_non_functional_component_infoin #24: a default answering "revision committed" would tell the UA the floor
moved while the old image stayed installable.
Breaking for out-of-repo
FdOpsimplementors. openprot needs one method onits four
MockFdOpsplus the real impl, on top ofnow(#19),handle_pending_component(#20) andget_non_functional_component_info(#24).