Conversation
The callback took a FirmwareComponent built from the three request fields with the other four filled in as dummies, and returned a bare u8 completion code. PendingComponent carries only the fields the request has, and PendingComponentResult limits the callback's answer to the three codes DSP0267 Table 44 leaves to the platform. Folding the estimated time into Activated keeps it from being set next to a completion code that cannot carry it, and into_response builds the response so the handler never orders the two fields itself.
chrysh
force-pushed
the
type-pending-component
branch
from
September 30, 2026 15:43
ae0fc2a to
dc29b50
Compare
chrysh
changed the base branch from
document-handle-pending-component
to
main
September 30, 2026 15:43
CourtneyDrant
left a comment
Collaborator
There was a problem hiding this comment.
This looks like a better direction to me and I will approve. However, the one thing we need to do is to return an error on 0xFFFF components. "Downstream Devices" have special meaning in PLDM. It means that the terminus is an FDP (Firmware Device Proxy) and not a FD. We have command support for FDPs in pldm-common but not in pldm-interface. In short, we don't support FDPs yet. Can we return InvalidComponentClassification on 0xFFFF Classifications until we do?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #29, now on main.
handle_pending_componenttook aFirmwareComponentwhose comparison stamp,version string, image size and option flags were dummies, and returned a bare
u8. An implementor could not tell which fields were real, or which completioncodes this command allows.
PendingComponentcarries only the three fields the request has, withdownstream_device_index()for the 0xFFFF case. The classification stays a rawu16, passed through as received, becauseComponentClassificationdoes notname every value that can arrive.
PendingComponentResulthas the three outcomes Table 44 allows, and theestimated time sits in
Activated(u16), so it cannot be sent next to the othertwo codes.
into_responsebuilds the response from it, so the handler neverpairs a completion code with a time itself.
The README section from #29 is updated to match.
Not in here:
activatehas the same bare-u8return; ifget_firmware_parmsfails this command sends no response at all instead of a completion code; and
the two error outcomes still encode the full response body with
estimated_timezero, where every other handler answers an error throughgenerate_failure_responsewith the completion code alone. That last one needsa DSP0267 Table 44 check on whether the field is present on an error. All
separate.
This is a breaking
FdOpschange, so openprot's next pin bump needs it on topof the three methods already pending there.