Conversation
DeviceConfig::new took a fifth parameter when the device table started carrying ComponentAttrs, and this call site was not updated, so //target/ast10x0/... stopped compiling. passive_required is what new_core already gives every component in this test's chain, so the table now says the same thing the chain does. Assisted-by: Claude
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ocp-global-demo-wipdoes not compile for the AST10x0 target right now.DeviceConfig::newtook a fifth parameter when the device table started carryingComponentAttrs, andtarget/ast10x0/tests/orchestrator/runtime/main.rsstill called it with four, so the Test job fails witherror[E0061]: this function takes 5 arguments but 4 arguments were suppliedand every PR against this base inherits the red.The device gets
ComponentAttrs::passive_required(), which is whatnew_corein the same file already gives every component in that test's chain, so the table and the chain now agree.Verified with
bazel build --keep_going --config=virt_ast10x0 //target/ast10x0/..., the same config theast10x0_qemu_testsrecipe uses: 31156 actions, completed successfully.