capabilities: Rename arm_trial to set_trial_pending - #534
Merged
chrysh merged 1 commit intoOct 3, 2026
Merged
Conversation
chrysh
marked this pull request as ready for review
October 3, 2026 19:43
The word was borrowed from watchdogs and alarms. A/B update systems call this marking the image pending, which is also what the state it writes is called. The prose follows: a pending mark the boot selector reads, set once and cleared when the trial is decided. The method name and the prose, no behaviour change. Assisted-by: Claude
chrysh
force-pushed
the
rename-trial-pending
branch
from
October 3, 2026 19:43
486bf08 to
1e16f44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arm_trialwas borrowed from watchdogs and alarms. A/B update systems call this marking the image pending, which is also what the state it writes is called,TrialPending.The method becomes
set_trial_pending, and the prose follows: "armed" becomes "marked pending", "the arming" becomes "the pending mark", "record-then-arm" becomes "record-then-mark", and "undoing the arming" becomes "clearing the pending mark".One file, the method name and its documentation. No behaviour change.
Other uses of "arm" in the tree are left alone: the i2c notification arming and the boot walk's
arm()andPhase::Armedare the watchdog sense, where the word reads correctly.