services: Fix the remaining clippy errors on the demo branch - #531
Merged
chrysh merged 2 commits intoOct 2, 2026
Merged
Conversation
Four crates, all reached only after the first clippy failure was fixed, because clippy stops at the first failing crate. None of them had ever been checked: no pull request against ocp-global-demo-wip ran CI. config: a single-arm match becomes if let, and Region gains is_empty next to len. pldm/server: ten test closures that only forwarded their argument become the function itself. update-api: RequestHeader::len is a wire field rather than a container length, so the lint is allowed in place. Assisted-by: Claude
A comma inside a sequenceDiagram participant alias ends the alias, so Loopback<D, N> failed to parse and the diagram rendered as an error box. The neighbouring participants carry no generics either. This does not fix the docs build. mdbook-mermaid still exits 1 with "Unable to parse the input", which is the preprocessor rejecting mdbook's RenderContext, not a diagram. Assisted-by: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#530 turned CI on for ocp-global-demo-wip and fixed the first clippy
error. Clippy stops at the first failing crate, so three more layers
were hiding behind it. Without these, every pull request against the
demo branch shows a red clippy run that is not its own.
config: a single-arm match becomes if let, and Region gains is_empty
next to len. pldm/server: ten test closures that only forwarded their
argument become the function itself. update-api: RequestHeader::len is a
wire field rather than a container length, so the lint is allowed in
place.
The docs commit fixes a mermaid diagram that failed to parse: a comma
inside a participant alias ends the alias. It does not fix the docs
build, which fails separately in mdbook-mermaid.
Assisted-by: Claude