pldm: Rename ipc-api and ipc-server to api and server - #514
Merged
Merged
Conversation
Every other service names its IPC crates by role, not by transport: services/i2c has api, client, client-ipc, server, services/mctp has api, client-ipc, server. The pldm seam was the only one carrying an ipc- prefix on crates that have no non-IPC counterpart to distinguish them from. Bazel targets follow: pldm_ipc_api becomes pldm_api, pldm_ipc_server becomes pldm_server. The Rust crate names come from the targets, so the use statements in the server move with them. Assisted-by: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other service names its IPC crates by role, not by transport:
services/i2chasapi,client,client-ipc,server, andservices/mctphasapi,client-ipc,server. The pldm seam was the only one with anipc-prefix on crates that have no non-IPC counterpart to distinguish them from.Bazel targets follow:
pldm_ipc_apibecomespldm_api,pldm_ipc_serverbecomespldm_server. The Rust crate names come from the targets, so theusestatements in the server move with them. Pure rename, no behaviour change.#510 rebases onto this and its crate lands as
services/pldm/client.