Update for parser change in webpack 5.109 - #411
Open
jeffrey-easyesi wants to merge 1 commit into
Open
jeffrey-easyesi wants to merge 1 commit into
jeffrey-easyesi wants to merge 1 commit into
Conversation
webpack/webpack#21451 removed the `.loc` property from expression nodes. To get the line/column, you must now call `parser.getLocation(expr)`. For the time being, it's probably best to keep compatible with older webpack versions too, hence the `expr.loc || parser.getLocation(expr)`. Fixes OpenNTF#404
|
|
chuckdumont
self-requested a review
September 23, 2026 19:13
chuckdumont
approved these changes
Sep 23, 2026
Collaborator
|
@jeffrey-easyesi - thanks for the fix. Could you please sign the Contributor License Agreement? |
Author
|
I've reached out to our legal team to get the OK on signing that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webpack/webpack#21451 removed the
.locproperty from expression nodes. To get the line/column, you must now callparser.getLocation(expr).For the time being, it's probably best to keep compatible with older webpack versions too, hence the
expr.loc || parser.getLocation(expr).Fixes #404