Flag within our list_rdm_tests tool if the WithExtraData tests are likely to be redundant due to a PID's maximum data size already being at the max PDL

(cherry picked from commit 372edee)

Author: peternewman

tools/rdm/list_rdm_tests.py

@@ -25,6 +25,7 @@
 import textwrap
 
 from ola import PidStore
+from ola.RDMConstants import RDM_MAX_PARAM_DATA_LENGTH
 
 __author__ = 'Peter Newman'
 
@@ -152,20 +153,22 @@ def GetWithExtraData(names, pid, pid_test_base_name, get_size):
     print('  """GET %s with more than %d byte%s of data."""' %
           (pid.name, get_size, 's' if get_size > 1 else ''))
     print('  PID = \'%s\'' % (pid.name))
+    if get_size >= RDM_MAX_PARAM_DATA_LENGTH:
+      print(("  # TODO(%s): Should we even have this test, get_size is "
+             "already at least the max PDL!") % (getpass.getuser()))
     dummy_data = GenerateDummyData(get_size)
     if dummy_data is None:
       print(("  # DATA = b'foo'  # TODO(%s): Specify extra data if this isn't "
              "enough.") % (getpass.getuser()))
-      print("  # Ensure the first %d bytes are sane/valid." % (get_size))
     elif dummy_data != 'foo':
       # Doesn't match default, explicitly set value
       print(("  DATA = b'%s'  # TODO(%s): Specify extra data if this isn't "
              "enough.") % (dummy_data, getpass.getuser()))
-      print("  # Ensure the first %d bytes are sane/valid." % (get_size))
     else:
       print(("  # DATA = b'%s'  # TODO(%s): Specify extra data if this isn't "
              "enough.") % (dummy_data, getpass.getuser()))
-      print("  # Ensure the first %d bytes are sane/valid." % (get_size))
+
+    print("  # Ensure the first %d bytes are sane/valid." % (get_size))
     print('')
     print('')
 
@@ -279,20 +282,22 @@ def SetWithExtraData(names, pid, pid_test_base_name, set_size):
                          'OptionalParameterTestFixture'])
     print('  """Send a SET %s command with extra data."""' % (pid.name))
     print('  PID = \'%s\'' % (pid.name))
+    if set_size >= RDM_MAX_PARAM_DATA_LENGTH:
+      print(("  # TODO(%s): Should we even have this test, set_size is "
+             "already at least the max PDL!") % (getpass.getuser()))
     dummy_data = GenerateDummyData(set_size)
     if dummy_data is None:
       print(("  # DATA = b'foo'  # TODO(%s): Specify extra data if this isn't "
              "enough.") % (getpass.getuser()))
-      print("  # Ensure the first %d bytes are sane/valid." % (set_size))
     elif dummy_data != 'foo':
       # Doesn't match default, explicitly set value
       print(("  DATA = b'%s'  # TODO(%s): Specify extra data if this isn't "
              "enough.") % (dummy_data, getpass.getuser()))
-      print("  # Ensure the first %d bytes are sane/valid." % (set_size))
     else:
       print(("  # DATA = b'%s'  # TODO(%s): Specify extra data if this isn't "
              "enough.") % (dummy_data, getpass.getuser()))
-      print("  # Ensure the first %d bytes are sane/valid." % (set_size))
+
+    print("  # Ensure the first %d bytes are sane/valid." % (set_size))
     print('')
     print('')