Refine some test categories and add and use some more constants in the RDM tests

(cherry picked from commit 4cf3d17)

Author: peternewman

python/ola/RDMConstants.py

@@ -20,6 +20,8 @@
 __author__ = 'nomis52@gmail.com (Simon Newton)'
 
 
+RDM_MAX_PARAM_DATA_LENGTH = 231
+
 RDM_ZERO_FOOTPRINT_DMX_ADDRESS = 0xFFFF
 
 RDM_MANUFACTURER_PID_MIN = 0x8000
@@ -43,6 +45,8 @@
 
 RDM_MAX_TEST_DATA_PATTERN_LENGTH = 4096
 
+RDM_MAX_SEARCH_DOMAIN_LENGTH = 231
+
 
 def _ReverseDict(input):
   output = {}

tools/rdm/TestCategory.py

@@ -34,6 +34,7 @@ class TestCategory(object):
     'DISPLAY_SETTINGS': 'Display Settings',
     'CONFIGURATION': 'Configuration',
     'CONTROL': 'Control',
+    'E133_MANAGEMENT': 'E1.33 (RDMnet) Management',
     # And others for things that don't quite fit
     'CORE': 'Core Functionality',
     'ERROR_CONDITIONS': 'Error Conditions',

tools/rdm/TestDefinitions.py

@@ -28,6 +28,7 @@
                               RDM_MANUFACTURER_SD_MAX, RDM_MANUFACTURER_SD_MIN,
                               RDM_MAX_DOMAIN_NAME_LENGTH,
                               RDM_MAX_HOSTNAME_LENGTH,
+                              RDM_MAX_SEARCH_DOMAIN_LENGTH,
                               RDM_MAX_SERIAL_NUMBER_LENGTH,
                               RDM_MAX_STRING_LENGTH,
                               RDM_MAX_TEST_DATA_PATTERN_LENGTH,
@@ -8450,11 +8451,14 @@ class AllSubDevicesGetSearchDomain(TestMixins.AllSubDevicesGetMixin,
   PID = 'SEARCH_DOMAIN'
 
 
-# class GetSearchDomain(TestMixins.,
-#                       OptionalParameterTestFixture):
-#   CATEGORY = TestCategory.
-#   PID = 'SEARCH_DOMAIN'
-# TODO(peter): Test get
+class GetSearchDomain(TestMixins.GetStringMixin,
+                      OptionalParameterTestFixture):
+  CATEGORY = TestCategory.E133_MANAGEMENT
+  PID = 'SEARCH_DOMAIN'
+  EXPECTED_FIELDS = ['search_domain']
+  PROVIDES = ['search_domain']
+  MAX_LENGTH = RDM_MAX_SEARCH_DOMAIN_LENGTH
+  # TODO(Peter): Validate invalid search domains?
 
 
 class GetSearchDomainWithData(TestMixins.GetWithDataMixin,
@@ -8465,7 +8469,7 @@ class GetSearchDomainWithData(TestMixins.GetWithDataMixin,
 
 # class SetSearchDomain(TestMixins.,
 #                       OptionalParameterTestFixture):
-#   CATEGORY = TestCategory.
+#   CATEGORY = TestCategory.E133_MANAGEMENT
 #   PID = 'SEARCH_DOMAIN'
 # TODO(peter): Test set
 
@@ -8476,12 +8480,6 @@ class SetSearchDomainWithNoData(TestMixins.SetWithNoDataMixin,
   PID = 'SEARCH_DOMAIN'
 
 
-class SetSearchDomainWithExtraData(TestMixins.SetWithDataMixin,
-                                   OptionalParameterTestFixture):
-  """Send a SET SEARCH_DOMAIN command with extra data."""
-  PID = 'SEARCH_DOMAIN'
-
-
 class AllSubDevicesGetBrokerStatus(TestMixins.AllSubDevicesGetMixin,
                                    OptionalParameterTestFixture):
   """Send a get BROKER_STATUS to ALL_SUB_DEVICES."""
@@ -8490,7 +8488,7 @@ class AllSubDevicesGetBrokerStatus(TestMixins.AllSubDevicesGetMixin,
 
 # class GetBrokerStatus(TestMixins.,
 #                       OptionalParameterTestFixture):
-#   CATEGORY = TestCategory.
+#   CATEGORY = TestCategory.E133_MANAGEMENT
 #   PID = 'BROKER_STATUS'
 # TODO(peter): Test get
 
@@ -8503,7 +8501,7 @@ class GetBrokerStatusWithData(TestMixins.GetWithDataMixin,
 
 # class SetBrokerStatus(TestMixins.,
 #                       OptionalParameterTestFixture):
-#   CATEGORY = TestCategory.
+#   CATEGORY = TestCategory.E133_MANAGEMENT
 #   PID = 'BROKER_STATUS'
 # TODO(peter): Test set