Automated testcase LTE features - #638
Conversation
awisniew90
left a comment
awisniew90
left a comment
There was a problem hiding this comment.
Test coverage looks good. Had a couple of changes.
| @@ -0,0 +1,188 @@ | |||
| package io.openliberty.tools.eclipse.test.it.utils; | |||
There was a problem hiding this comment.
I think we should remove this class and instead have each of the constants just be a part of the respective test classes. e.g. all MP constants should be part of the LibertyPluginSWTBotMicroProfileTest class.
There was a problem hiding this comment.
Addressed review comment- kept constants as part of the respective test classes. Thanks
| * Method to open file for the test cases | ||
| * | ||
| */ | ||
| public static SWTBotEclipseEditor openFileForTest(SWTWorkbenchBot bot) { |
There was a problem hiding this comment.
Would be good to make this method generic with 3 properties: appName, packageName, fileName.
There was a problem hiding this comment.
Addressed. Thanks
| //Open Project Explorer | ||
| bot.viewByTitle("Project Explorer").show(); | ||
|
|
||
| SWTBotTreeItem javaFile = bot.tree().expandNode("liberty.maven.test.app (in liberty-maven-test-app)").expandNode("src").expandNode("main").expandNode("java").expandNode("test").expandNode("maven").expandNode("liberty").expandNode("web").expandNode("app").getNode("FieldConstraintValidation.java"); |
There was a problem hiding this comment.
This should use the SWTBotPluginOperations.openFileForTest method
There was a problem hiding this comment.
Addressed. Thanks
| // Open Project Explorer | ||
| bot.viewByTitle("Project Explorer").show(); | ||
|
|
||
| SWTBotTreeItem javaFile = bot.tree().expandNode("liberty.maven.test.app (in liberty-maven-test-app)").expandNode("src").expandNode("main").expandNode("java").expandNode("test").expandNode("maven").expandNode("liberty").expandNode("web").expandNode("app").getNode("FieldConstraintValidation.java"); |
There was a problem hiding this comment.
Same as other call - we can use the new method you added to SWTBotPluginOperations
There was a problem hiding this comment.
I didnt flag each place in the other files, but where you are opening files, you should call your new helper method instead.
There was a problem hiding this comment.
Addressed. Thanks
| * Verify the class level snippets are available for Microprofile | ||
| * | ||
| */ | ||
|
|
There was a problem hiding this comment.
A few places had an extra line here between the method comment header and the code.
There was a problem hiding this comment.
Addressed. Thanks
SuparnaSuresh
changed the title
6786b40 to
86bed55
Compare
2 participants
Fixes #653 - Test cases added for the Jakarta Microprofile features.