Avoided real docker/podman container CLI check for tests - #537
Merged
venmanyarun merged 1 commit intoSep 2, 2026
Merged
Conversation
cherylking
approved these changes
Sep 1, 2026
Contributor
|
@sajeerzeji |
Contributor
Author
Before implementing the fix: Screen.Recording.2026-09-02.at.10.46.29.AM.movAfter implementing the fix: Screen.Recording.2026-09-02.at.10.48.09.AM.mov |
venmanyarun
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Docker is not running but installed in the system, the printPortInfo tests were failing.
The root cause was the test already mocks the container state, but printPortInfo also triggers real CLI calls, first running docker version / podman version to detect the container engine, then fetching network info. When Docker is installed but not running, the version check throws a RuntimeException, and will fail the tests. In CI it works because no docker or podman installed.
Fixed this by overriding execContainerCmdWithPrefix to return null in BaseDevUtilTest, so it will never call the real docker or podman CLI.