Repository navigation
Conversation
|
@Bigtura Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Bigtura
force-pushed
the
fix/issue-1396-be-131-knightverse-core-binary-panics-at
branch
from
October 22, 2026 00:17
62be37a to
e709120
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a startup panic in the
knightverse-corebinary caused by initialising the global tracing subscriber twice. Tracing is now initialised in a single place, and the library usestry_init()so a second registration no longer panics.Related Issue
Changes
🔧 Tracing Initialisation Fix
[MODIFY]
backend/src/main.rstracing_subscriber::fmt().init()call so the binary no longer registers a global subscriber before delegating to the library entry point.[MODIFY]
backend/modules/api/src/server.rstry_init()so it tolerates an already-registered global subscriber instead of panicking.Verification Results
try_init()in the library)main.rs; library usestry_init()Closes #1396