Skip to content

Fix #29: Overflow on Starting with Minutes and Hours #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cornelius-koepp wants to merge 1 commit into
base: v1dev
Choose a base branch
from
+12 −2
Draft

Fix #29: Overflow on Starting with Minutes and Hours #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "OFM-FunctionBlocks",
"version": "0.10.0",
"version": "0.10.1",
"description": "Function Blocks",
"homepage": "https://openknx.de",
"authors": {
Expand Down
10 changes: 10 additions & 0 deletions release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Release Notes

## 0.10.1
### Breaking Changes
- none

### Feature
- none

### Bug
- Fix #29: Dauer war durch uint8_t Berechnung auf 255s beschränkt bei "Start mit Zeit" in {"Einheit Minuten", "Einheit Stunden"}

## 0.10.0
### Breaking Changes
- none
Expand Down
2 changes: 1 addition & 1 deletion src/FunctionBlocks/CountDownBlock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ void CountDownBlock::handleKo(GroupObject &ko)
break;
}
case FCB_KoCHStartWithTime: {
uint8_t value = ko.value(DPT_Value_1_Ucount);
uint32_t value = ko.value(DPT_Value_1_Ucount);
// <Enumeration Id="%ENID%" Value="0" Text="Deaktiviert" />
// <Enumeration Id="%ENID%" Value="1" Text="Sekunden" />
// <Enumeration Id="%ENID%" Value="2" Text="Minuten" />
Expand Down