[difanz]

FH8626V100 boards wire SD0 with one data line (the vendor U-Boot configures SD0_1BIT_NO_WP) and use the D1 pad as a GPIO; on the cameras it drives a PTZ motor phase. The released openipc-fullhan build muxes D1–D3 to SD and runs 4-bit. This patch leaves those pads alone and drops 4-bit mode for FH8626, as already done for the FH8632.

Tested on an FH8626V100 camera.

Released build: SPI NOR and console work, but the card isn’t read.

This build:

1. mmc info shows the card in 1-bit mode at 25 MHz.
2. Files loaded from FAT match the same data read from flash.
3. A 4 MiB file loads the same twice.
4. SPI NOR reads the same at 50 MHz and at 10 MHz.
5. Console input works with the existing pad table.
6. It boots the OpenIPC 4.19 kernel.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Use 1-bit SD0 mode on FH8626V100 boards

🐞 Bug fix 🕐 Less than 10 minutes

AI Description

• Leave FH8626 SD0 D1–D3 pads untouched because camera boards use D1 as GPIO.
• Disable 4-bit MMC negotiation so SD cards work with the board’s 1-bit wiring.

Diagram

graph TD
  B["FH8626 board"] --> P["SD0 pinmux"] --> S["SD card"]
  B --> G["D1-D3 untouched"]
  B --> M["MMC init"] --> D["DW MMC"] --> S

Loading

High-Level Assessment

The board-specific pinmux change and reuse of FH8632’s 4-bit capability restriction fit the existing design. Changing the shared DesignWare MMC driver would broaden the scope without a demonstrated need.

Files changed (1) +5 / -4

Bug fix (1) +5 / -4

fullhan.cLimit FH8626 SD0 to its wired 1-bit bus +5/-4

Limit FH8626 SD0 to its wired 1-bit bus

• Removes FH8626 pinmux entries for SD0 D1–D3, preserving those pads for other uses. Extends the existing FH8632 post-registration MMC capability restriction to FH8626 so the host does not advertise 4-bit mode.

board/fullhan/fullhan/fullhan.c

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can pick a display mode instead of tweaking every Display option by hand

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗