Skip to content

ambarella-osdrv-s3l: generate the OV4689 ISP configuration at build time #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openipc-ai merged 1 commit into from
Nov 8, 2026
Merged

ambarella-osdrv-s3l: generate the OV4689 ISP configuration at build time #2793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions general/package/legacy/ambarella-osdrv-s3l/ambarella-osdrv-s3l.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

AMBARELLA_OSDRV_S3L_SITE_METHOD = local
AMBARELLA_OSDRV_S3L_SITE = $(AMBARELLA_OSDRV_S3L_PKGDIR)/src
AMBARELLA_OSDRV_S3L_LICENSE = MIT (load_ucode), PROPRIETARY (modules, microcode)
AMBARELLA_OSDRV_S3L_LICENSE = MIT (load_ucode, ISP generator), PROPRIETARY (modules, microcode)

# load_ucode puts the DSP microcode in place. files/firmware is the generic set
# from Ambarella's S3L SDK release 2.5.0_20181109 (2018/10/28, 284712.282649),
Expand All @@ -21,8 +21,19 @@ AMBARELLA_OSDRV_S3L_LICENSE = MIT (load_ucode), PROPRIETARY (modules, microcode)
AMBARELLA_OSDRV_S3L_DEPENDENCIES = linux
AMBARELLA_OSDRV_S3L_IAV_OFFSETS = INODE_I_CDEV:272 FILE_PRIVATE_DATA:112

# The ISP configuration Divinus loads into the DSP (/etc/sensors/<sensor>.bin) is generated
# here from src/isp's presets, one per sensor; nothing comes from a camera's firmware. Only
# Divinus reads it (Majestic does not), so it is built and installed only with Divinus.
ifeq ($(BR2_PACKAGE_DIVINUS),y)
AMBARELLA_OSDRV_S3L_ISP_SENSORS = ov4689
AMBARELLA_OSDRV_S3L_DEPENDENCIES += host-python3
endif

define AMBARELLA_OSDRV_S3L_BUILD_CMDS
$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) load_ucode
for s in $(AMBARELLA_OSDRV_S3L_ISP_SENSORS); do \
$(HOST_DIR)/bin/python3 $(@D)/isp/s3l_isp_gen.py $(@D)/isp/$$s.bin --preset $(@D)/isp/$$s.yaml || exit 1; \
done
$(LINUX_MAKE_ENV) $(MAKE) -C $(LINUX_DIR) $(LINUX_MAKE_FLAGS) \
M=$(@D)/abi abi_probe.s
for want in $(AMBARELLA_OSDRV_S3L_IAV_OFFSETS); do \
Expand All @@ -37,8 +48,10 @@ define AMBARELLA_OSDRV_S3L_BUILD_CMDS
endef

define AMBARELLA_OSDRV_S3L_INSTALL_TARGET_CMDS
$(INSTALL) -m 755 -d $(TARGET_DIR)/etc/sensors
# $(INSTALL) -m 644 -t $(TARGET_DIR)/etc/sensors $(AMBARELLA_OSDRV_S3L_PKGDIR)/files/sensor/config/*.cfg
$(if $(AMBARELLA_OSDRV_S3L_ISP_SENSORS),$(INSTALL) -m 755 -d $(TARGET_DIR)/etc/sensors)
for s in $(AMBARELLA_OSDRV_S3L_ISP_SENSORS); do \
$(INSTALL) -m 644 $(@D)/isp/$$s.bin $(TARGET_DIR)/etc/sensors/$$s.bin || exit 1; \
done

$(INSTALL) -m 755 -d $(TARGET_DIR)/lib/modules/3.10.104/ambarella
$(INSTALL) -m 644 -t $(TARGET_DIR)/lib/modules/3.10.104/ambarella $(AMBARELLA_OSDRV_S3L_PKGDIR)/files/kmod/*.ko
Expand Down
11 changes: 11 additions & 0 deletions general/package/legacy/ambarella-osdrv-s3l/src/isp/ov4689.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# OmniVision OV4689: S3L ISP configuration, generated at build time (no vendor tuning).
# Values here are the sensor's, shared by every OV4689 board; a board that needs its own file points the
# streamer at it (Divinus: system.sensor_config), which takes precedence over /etc/sensors/ov4689.bin.
width: 2688
height: 1520
bayer: 1
black_level: 244 # the sensor's BLC target 0x40 (10-bit) is a nominal 256; a dark frame's median sits at ~244
wb_gain: 1.5,1.8 # starting point only: the streamer's auto white balance replaces it from the first frames
dbp: 4,32 # dynamic bad-pixel correction
sharpness: medium
temporal_nr: med # motion-compensated temporal noise reduction
Loading
Loading