Repository navigation
sigmastar-osdrv-infinity6c: ship an sc850sl IQ file, the one Anjoy's MC-J86 runs - #2792
Merged
Merged
Conversation
…MC-J86 runs Since af185df (#1471) the infinity6c images carry no sc850sl.bin, so an SC850SL board streams with an untuned ISP: flat, washed-out colour (#2758). The 2024 sc850sl.bin that commit removed was tried on the same camera and is worse: near-grey and dark. This is Anjoy's tuning from the MC-J86 stock firmware V3.6.1.3, where it ships as config/iqfile/gc4023_day.bin (Anjoy names every IQ file gc4023_* whatever the sensor; isp_source.txt beside it reads cfg/sc850sl). sha256 ae30daee9acb1a0ae39853a3335e61e96f7274c55efb82f9f2a51ac2b60aa18a. It is a vendor binary with no buildable source, which the tree normally refuses; the maintainers took it knowingly because no open tuning for this sensor exists. It is installed only as /etc/sensors/sc850sl.bin, so boards with other sensors are unaffected, and it compresses to about 8 KB against the 48 KB of squashfs headroom these boards have.
openipc-ai
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
November 7, 2026 18:04
Code Review by QodoNo Changes in PRQodo reviewed your PR and found no changes in the codeTip of the day💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
On infinity6c, an SC850SL camera streams with an untuned ISP: the picture is flat and washed out. The image has had no
sc850sl.binsince af185df (#1471), and majestic runs on without one. Reported on an Anjoy MC-J86 (SSC378DE + SC850SL, 16 MB NOR) in #2758.Change
Adds
general/package/sigmastar-osdrv-infinity6c/files/sensor/configs/sc850sl.bin, installed as/etc/sensors/sc850sl.bin. The package already installs everyconfigs/*.bin, andload_sigmastaralready has ansc850slarm, so no other file changes.The file is Anjoy's tuning from the MC-J86 stock firmware V3.6.1.3, archived as anjoyupdates r1849. There it ships as
config/iqfile/gc4023_day.bin: Anjoy names every IQ filegc4023_*whatever the sensor, and theisp_source.txtbeside it reads.../cfg/sc850sl. The reporter's own factory backup has the same file set.ae30daee9acb1a0ae39853a3335e61e96f7274c55efb82f9f2a51ac2b60aa18aPolicy
This is a vendor binary with no buildable source. The tree normally refuses that (
pr_compliance_checklist.yaml), and this PR knowingly makes an exception, as a maintainer decision. No open tuning exists for SC850SL. The only other candidate is the 2024sc850sl.binfrom 95fa0e0, which is worse on this camera (see the evidence below).Evidence
Collected by the reporter on the MC-J86, with the file installed by hand at
/etc/sensors/sc850sl.bin(#2758 snapshots):sc850sl.bin(95fa0e0)This PR's built image has not been run on a camera. The evidence is the same file placed by hand on a Nov 5 nightly.
Reach and size
sc850slloads it, so other sensors are unaffected.