Repository navigation
ambarella: s3l: ship majestic - #2785
Merged
Merged
Conversation
The s3l lite build of majestic is now published (majestic.s3l.lite.master.tar.bz2), so the image can carry it like every other lite board, with its fonts. BR2_PACKAGE_MAJESTIC selects json-c and libyaml; the rest of what the binary links (libevent, mbedtls, opus, ogg, zlib) was already in the defconfig.
widgetii
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
November 7, 2026 06:49
PR Summary by QodoEnable Majestic and fonts in the Ambarella S3L lite image
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
BR2_PACKAGE_MAJESTICandBR2_PACKAGE_MAJESTIC_FONTSins3l_lite_defconfig.The s3l lite majestic build is now published to S3 as
majestic.s3l.lite.master.tar.bz2, the namemajestic.mkasks for withOPENIPC_SOC_FAMILY=s3landOPENIPC_MAJESTIC=lite.Verified:
make BOARD=s3l_lite defconfigresolvesBR2_PACKAGE_MAJESTIC=ywithJSON_C,LIBYAMLandZLIBselected./lib/ld-musl-armhf.so.1). Every library it links (json-c, libyaml, zlib, opus, ogg, mbedtls, libevent 2.2) is in the image./image.jpgreturns a snapshot.