Repository navigation
ci: build s3l_lite - #2783
Merged
Merged
ci: build s3l_lite#2783
Conversation
S3L sat in UNBUILT_FAMILIES, so a change to its kernel config or its package reached users with no build at all, and five bring-up pull requests have landed that way. Its toolchain is published and the image fits, so the reason is gone. It also joins the smoke set, because no other board there has its vendor or its squashfs-plus-UBI layout. The nightly now publishes its images as well.
openipc-ai
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
November 7, 2026 06:17
PR Summary by QodoBuild s3l_lite in CI and publish nightly images
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
S3L is in
UNBUILT_FAMILIES, soci-matrix.pygives 0 boards for its kernel config, and only the smoke set, without S3L, for its package. #2763, #2764, #2766, #2768 and #2780 all landed with no S3L build in CI, and the green CI Gate on #2781 and #2782 says nothing about this board.Change
s3l_litemoves intoALL_BOARDS, and the family leavesUNBUILT_FAMILIES.SMOKE_BOARDS, because--self-testrequires every vendor and rootfs layout to be covered there. Without that it fails withno board in SMOKE_BOARDS has vendor:ambarella.Effect beyond CI
The nightly starts publishing S3L images (
openipc.s3l-nor-lite.tgzandopenipc.s3l-nand-lite.tgz), becausePublish releasesuploads everyopenipc*.tgzthe matrix builds. That matters for three reasons:Hardware tested on
Not run on a camera. This changes which boards CI builds, not what's in any image, and every other board's image is unaffected.
Evidence
python3 .github/scripts/ci-matrix.py --self-test:Before, for the kernel config and the package:
After, both paths:
A local
make BOARD=s3l_litewith the published toolchain passes, including with #2782's microcode: uImage 1582/2048 KB, squashfs 4156/5120 KB, UBI 8960/16384 KB.check_target_modules.shreports all expected modules present on that build. This PR's own CI run should builds3l_liteas the first CI proof.Scope
general/package/all-patches/linux/(those go to OpenIPC/linux)general/overlay/or in a sharedload_<vendor>script hardcodes a value specific to my boardLD_PRELOAD, and no binaries that cannot be rebuilt from source