[DeathCamel58]

The HAL_* macros pick their colours with isatty(STDERR_FILENO) before the message's arguments are evaluated. When stderr isn't a terminal (a log file, a pipe, a service manager), isatty() sets errno to ENOTTY. So every HAL message that reports strerror(errno) printed "Not a tty" (musl) or "Inappropriate ioctl for device" (glibc) instead of the actual failure. The colour test now saves and restores errno (hal_stderr_is_tty() in src/hal/macros.h).

Found by openipc-ai while running the S3L backend (#71) with its log redirected: an ioctl that returned EPERM was reported as "Not a tty".

Tested with errno = EPERM; HAL_DANGER("test", "ioctl failed: %s\n", strerror(errno));:

	stderr to a file	stderr on a terminal
before	ioctl failed: Inappropriate ioctl for device	ioctl failed: Operation not permitted
after	ioctl failed: Operation not permitted	ioctl failed: Operation not permitted

Divinus also builds with it for S3L (VFPv3 musl toolchain) and on the host. It touches only the header, so every platform picks it up.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Preserve errno when HAL logs to a file or pipe

🐞 Bug fix 🕐 Less than 10 minutes

AI Description

• Preserve the original errno across HAL's terminal check so redirected logs report the actual
 failure.
• Keep terminal color behavior unchanged for all HAL logging macros.

Diagram

graph TD
    A["Original errno"] --> B["HAL logging macro"] --> C["HAL_COLOR"] --> D["Terminal check"] --> E["Restore errno"] --> F["Format message"]

Loading

High-Level Assessment

Keeping errno preservation in the shared terminal-check helper is the narrowest fix: it protects every HAL_COLOR use without changing the logging macros' formatting or color behavior. Wrapping each logging macro separately would duplicate the fix.

Files changed (1) +10 / -1

Bug fix (1) +10 / -1

macros.hPreserve errno during HAL terminal detection +10/-1

Preserve errno during HAL terminal detection

• Adds an inline helper that saves errno, calls isatty on stderr, and restores errno before returning the result. HAL_COLOR now uses the helper, preventing redirected logging from replacing an error reported through strerror(errno) with ENOTTY.

src/hal/macros.h

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can pick a display mode instead of tweaking every Display option by hand

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗