Skip to content

Fix build with LTO - #189

Open
yochananmarqos wants to merge 1 commit into
OpenGamingCollective:mainfrom
yochananmarqos:patch-1
Open

Fix build with LTO#189
yochananmarqos wants to merge 1 commit into
OpenGamingCollective:mainfrom
yochananmarqos:patch-1

Conversation

@yochananmarqos

@yochananmarqos yochananmarqos commented Aug 15, 2026

Copy link
Copy Markdown

Description

Using the system SQLite avoids the build failure with LTO enabled.

See https://manual.archlinux.page/package-guidelines/rust/#unbundling-cc-libraries

Checklist:

  • My code follows the style guidelines of this project (cargo fmt)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the mdBook documentation
  • My changes generate no new warnings (clippy/clang)
  • New and existing unit tests pass locally with my changes (either use nix flake check or wait for the ci)

Using the system SQLite avoids the build failure with LTO enabled. 

See https://manual.archlinux.page/package-guidelines/rust/#unbundling-cc-libraries
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 250b6a75-b97f-4b67-9575-96b80849df18

📥 Commits

Reviewing files that changed from the base of the PR and between c5e8dcd and 1b49422.

📒 Files selected for processing (1)
  • packages/arch-linux/cardwire-PKGBUILD

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Arch Linux package to include SQLite as a required runtime dependency.
    • Improved build configuration to use the system SQLite installation.
  • Chores
    • Removed the package’s disabled link-time optimization setting.

Walkthrough

The Arch Linux package now declares sqlite as a runtime dependency and configures compilation to use pkg-config for SQLite. The !lto package option was removed.

Changes

Arch Linux packaging

Layer / File(s) Summary
SQLite dependency and build configuration
packages/arch-linux/cardwire-PKGBUILD
The package adds sqlite to its runtime dependencies, removes the !lto option, and sets LIBSQLITE3_SYS_USE_PKG_CONFIG=1 before compilation.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 1b494

This is a localized build-packaging change to use system SQLite for LTO compatibility, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: luytan

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: fixing the build when LTO is enabled.
Description check ✅ Passed The description summarizes the change and includes the checklist, but it omits the TODO section and issue reference.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant