Fix PhaseSpaceActor scoring in nested attached volumes#975
Open
nkrah wants to merge 3 commits into
Open
Conversation
Contributor
|
Hello @nkrah |
tbaudier
reviewed
Apr 21, 2026
|
|
||
| const auto history_depth = touchable->GetHistoryDepth(); | ||
| int attached_volume_depth = -1; | ||
| for (int i = 0; i <= history_depth; i++) { |
Contributor
There was a problem hiding this comment.
Why did you do a for loop instead of looking for the name of touchable->GetVolume(0)?
| // actor) internal surface crossing | ||
| if (!IsStepInTopAttachedVolume(step)) | ||
| return; | ||
|
|
Contributor
There was a problem hiding this comment.
How can we manage the others policy of the storing: ‘exiting’, ‘first’ or ‘all’
|
|
||
| // Check if this SteppingAction was triggered via the sensitive detector | ||
| // attached to the top volume, i.e. the "attached_to" volume | ||
| // if it was triggered by a daughter volume, this is not truely a step |
Contributor
There was a problem hiding this comment.
We need to pay attention to daughter volume with same boundary than mother volume when the particle enters.
Or if the particle is created inside a daughter volume like in test058 with iec spheres, the mother volume is the world
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation:
PhaseSpaceActor is attached to a single volume in GATE, but the underlying sensitive detector registration is recursive over the attached volume hierarchy. This can lead to surprising extra phase-space entries when daughter volumes are crossed.
Changes:
Notes: