Small fixes to PositroniumSource implementation#768
Open
wkrzemien wants to merge 5 commits into
Open
Conversation
The previous version always assumed that PPs is defined as a first element. The current version should work for any order. Also, the pPs time is set to the value provided by user, before it was using some default constant. Still this function assumes that only one PPs is defined.
should give error in this particular case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version always assumed that pPs is defined as the first element. The current version should work for any order. Also, the pPs time is set to the value provided by the user; it used some default constant. This function assumes that only one PPs is defined.
PositronElectronInteraction::kParaPsaraPositroniuminGatePositroniumHelper::CalcFractionsFromLifetime