[BugFix] Error in Quaternion_to_DCM calculation#3355
Merged
Conversation
The third term in the calculation was incorrect. This routine has not been used since it was added in 2014, so no results will be affected. This was reported on the forum here: https://forums.nlr.gov/t/beamdyn-questions/9518/3
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes an incorrect term in the quaternion-to-direction-cosine-matrix (DCM) conversion that previously squared the wrong quaternion component.
Changes:
- Corrected the
q3q3term to useq%v(3)instead ofq%v(2)inQuaternion_to_DCM.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Part of the third term in the calculation was incorrect.
Related issue, if one exists
This was reported by Alban.Leroyer on the forum here: https://forums.nlr.gov/t/beamdyn-questions/9518/3
Impacted areas of the software
This routine has not been used since it was added in 2014, so no results will be affected.
Generative AI usage
Calculation checked by: Google Gemini gemini@google.com
Test results, if applicable
None