feat(ui/user): expose theme switcher for OpenEMS theme - #3945
Merged
sfeilmeier merged 9 commits intoSep 4, 2026
Merged
Conversation
Introduces `isThemeSelectionAvailable` getter in UserComponent that returns true for OpenEMS, FENECON, and FENECONBeta themes, replacing the hard-coded FENECON/FENECONBeta check in the template. Closes OpenEMS#3944
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3945 +/- ##
=============================================
- Coverage 55.88% 55.34% -0.54%
- Complexity 19348 19443 +95
=============================================
Files 3705 3840 +135
Lines 173321 177237 +3916
Branches 14254 14801 +547
=============================================
+ Hits 96844 98074 +1230
- Misses 72641 75286 +2645
- Partials 3836 3877 +41 🚀 New features to boost your workflow:
|
Covers all four Theme values: OpenEMS (new), FENECON, FENECONBeta (true) and Heckert (false).
Christoph-87
force-pushed
the
feat/theme-switcher-for-openems-theme
branch
from
September 3, 2026 12:54
1729192 to
308ad9f
Compare
sfeilmeier
requested changes
Sep 3, 2026
…ly field Calling a getter from a template is evaluated on every change-detection cycle. Since environment.theme is fixed at build time the value never changes, so a readonly field computed once at instantiation is sufficient.
…buy price is shown When gridBuyPrice is present both text elements (kW value and price) are shifted up by 25 px so they appear above the grid icon. The icon position stays unchanged to keep alignment with the consumption section icon. The offset is applied lazily in _updateCurrentData because gridBuyPrice requires an async config fetch and is always null when setElementHeight runs. setElementHeight resets the tracking flag so the offset is correctly re-applied after a window resize.
…en grid buy price is shown" This reverts commit 52df53e.
…tisfy member-ordering lint rule
sfeilmeier
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
isThemeSelectionAvailablegetter in UserComponent that returns true for OpenEMS, FENECON, and FENECONBeta themes, replacing the hard-coded FENECON/FENECONBeta check in the template.Closes #3944