Feature/controller ess cycle surplusfeedtogrid selltogridlimit reference target - #3903
Open
PunugupatiSaikumar wants to merge 5 commits into
Conversation
added 3 commits
August 21, 2026 09:23
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3903 +/- ##
=============================================
+ Coverage 55.64% 55.64% +0.01%
- Complexity 19016 19017 +1
=============================================
Files 3670 3670
Lines 171447 171439 -8
Branches 14113 14108 -5
=============================================
+ Hits 95377 95378 +1
+ Misses 72302 72298 -4
+ Partials 3768 3763 -5 🚀 New features to boost your workflow:
|
sfeilmeier
requested changes
Aug 22, 2026
| @@ -68,23 +70,18 @@ public ControllerEssCycleImpl() { | |||
| @Activate | |||
| private void activate(ComponentContext context, Config config) { | |||
Contributor
There was a problem hiding this comment.
Please remove ComponentContext context as well, it's not required anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates three ESS controllers to the Reference Target Plugin (
@GenerateTargetsFromReferences).Bundles:
For each bundle:
OpenemsComponent.updateReferenceFilter()with a static target filter on@ReferenceConfigurationAdminwhere it was only used for thatess_target()/meter_target()from Config and MyConfig where they existedDummyConfigurationAdminSellToGridLimit uses two references (
essandmeter). Cycle and SurplusFeedToGrid each use a singleessreference.