Skip to content

Call getModalComponent after ioComponents are initialized - #3774

Open
chpoulter wants to merge 5 commits into
OpenEMS:developfrom
chpoulter:feature/FixIoApiDigitalInputComponent
Open

chpoulter wants to merge 5 commits into
OpenEMS:developfrom
chpoulter:feature/FixIoApiDigitalInputComponent

Conversation

@chpoulter

@chpoulter chpoulter commented Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

I noticed that IO state is not shown anymore in the UI. I'm not that deep in angular, but I think this is because modalComponent is created to early. At this point ioComponents is not filled yet.

I move it to the end into the then() of getConfig(). Now it works as expected.

@codecov

codecov Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.20605% with 969 lines in your changes missing coverage. Please review.

❌ Your patch check has failed because the patch coverage (54.21%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3774      +/-   ##
=============================================
- Coverage      55.42%   55.33%   -0.09%     
- Complexity     18781    19442     +661     
=============================================
  Files           3624     3840     +216     
  Lines         169392   177237    +7845     
  Branches       13986    14801     +815     
=============================================
+ Hits           93873    98059    +4186     
- Misses         71799    75300    +3501     
- Partials        3720     3878     +158     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants