[EDGE] Official driver of PLCnext platform of Phoenix Contact - #3555
[EDGE] Official driver of PLCnext platform of Phoenix Contact#3555mbreier-sw wants to merge 30 commits into
Conversation
…fficial_plcnext_driver_2' Official drivers for PLCnext platform added See merge request pxc/openems!35
…fficial_plcnext_driver_2' error handling, logging improvements See merge request pxc/openems!37
…fficial_plcnext_driver_2' Minor adjustments See merge request pxc/openems!39
|
@ALL: What about review? |
…fficial_plcnext_driver_2' Integration of optimizations from PxC See merge request pxc/openems!42
|
First of all thank you for your Contribution. Just one Question beforehand: Why is the tools/phoenix needed? To keep the Packages clean i would prefer not to Push "non-generic" Files or "User-Changeable" Files to the Repo except it is impossible to run the Code with it which i don't think here :D @mbreier-sw In my Opinion and as far as I see this it is not needed and shoul be removed. |
@Sn0w3y : You are totally right, the folder contains supporting scripts for the deployment on PLCnext controller. They shouldn't be checked into the generic "tools" folder. Update: Files have been moved to the modules "doc" folder, because they can be used as examples to deploy OpenEMS to PLCnext controllers. |
|
@Sn0w3y : Sorry for bothering ... Are there any news to this PR? |
…fficial_plcnext_driver_2' Fixes due to code review See merge request pxc/openems!44
|
@Sn0w3y : We've finished the internal review of this branch and fixed the issues. What about the official review? |
|
@Sn0w3y & @sfeilmeier : Any update regarding this PR? |
sfeilmeier
left a comment
sfeilmeier
left a comment
There was a problem hiding this comment.
I started applying Checkstyle, but there is just too many. Could you please fix Checkstyle violations? (see also Coding Guidelines at https://openems.github.io/openems.io/openems/latest/development/coding-guidelines.html#_openems_edge_backend)
We need to find a way on how to handle documentation. The way it is right now, it's quite hidden. We usually just use the readme.adoc files and copy them over to our Antora Docs - see for example: https://openems.github.io/openems.io/openems/latest/edge/bridge.d/io.openems.edge.bridge.http.html; but that's without images.
We could move all your docs to the main /docs folder to have it properly attached to Antora. Or we find a way to integrate the images with the Antora build... At least you should mention the docs inside the readme, otherwise nobody will find them.
I did not yet look into the details of the code logic. Maybe you should have a look at HttpBridgeAuthenticationService which was added recently. It might help with updating the authentication token.
|
Will check and adjust this. Thanks for the feedback @sfeilmeier. |
5 participants
New drivers for PLCnext Meter, ESS, PV-Inverter and Load-Circuit/PCU/EZA added using PLCnext REST-API