Repository navigation
fix:hybrid retriever: reuse query embedding across retries - #38
Open
KeyCOrigin wants to merge 2 commits into
Open
KeyCOrigin wants to merge 2 commits into
KeyCOrigin wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
HybridRetriever._retrieve, the vector-search step is wrapped byrecover_readand can be retried when the vector store read fails. Beforethis change, every retry called
embed_query(query)again, even though thequery text never changes across retries.
This PR caches the query embedding for the duration of a single retrieval:
embed_query(query)once, before the first vector query.attempt re-embeds (no stale value is reused).
Changes
datamind/capabilities/kb/providers/hybrid_retriever.pyquery_vectorlocal that holds the completedembedding across
recover_readretries.stage = "kb.embedding"to run only when the embedding isactually computed.
versioned reads, and fallback behaviour).
Notes
cross-request embedding cache is added here.
Verification
python3 -m py_compile datamind/capabilities/kb/providers/hybrid_retriever.pypasses.