Skip to content

fix(release): avoid SIGPIPE when reading patch subject - #322

Open
BunsDev wants to merge 1 commit into
mainfrom
fix/patch-bullet-subject-current-main
Open

BunsDev wants to merge 1 commit into
mainfrom
fix/patch-bullet-subject-current-main

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 16, 2026

Copy link
Copy Markdown
Member

Summary

  • Read the first line of the patch commit message with Bash parameter expansion. The previous printf | head pipeline exits 141 under pipefail for a long multiline body and prevents the patch bullet from being written.
  • Add a fixture that runs the workflow's actual shell step and checks long bodies, marker handling, literal shell data, output, and file effects.

Context

  • Related request: Goal 3 surface audit, manifest position 124 (logical unit 127).
  • Scope: .github/workflows/auto-release.yml and scripts/test_patch_bullet.py.
  • Non-goals: release dispatch, versioning, publication, and the separate flaky query test.

Changes

  • Replace the first-line printf | head pipeline with ${MSG%%$'\n'*}.
  • Preserve the existing marker removal, empty-subject fallback, SHA link, and patch output format.

Validation

  • git diff --check and git diff --cached --check: pass.
  • python3 scripts/test_patch_bullet.py: reproduced two exit-141 failures before the change; 3 methods and 11 cases pass after it.
  • python3 scripts/test_release_markers.py: 5 pass.
  • actionlint .github/workflows/auto-release.yml: pass.
  • cargo fmt --all -- --check: pass.
  • cargo check --workspace --all-targets --locked: pass with two build jobs.
  • cargo clippy --workspace --all-targets --locked -- -D warnings: pass with two build jobs.
  • cargo test --workspace --locked: rerun passes, 2,666 passed, 0 failed, 38 ignored across 104 result groups, using scratch Coven homes. The first run failed only at the known queued_stop_hook_rechecks_goal_before_child_start 30 ms timing test; that test passed alone on the unchanged tree and is a separate Goal 3 fix.
  • scripts/tui-tests/run.sh: not applicable; no TUI or input code changed.

PR Readiness

  • Diff is limited to the intended files.
  • Generated files were not edited by hand.
  • User-facing docs/help are not needed for this workflow correction.
  • No secrets, credentials, local paths, or unrelated logs are included.
  • Remaining risk: the known query timing test can still fail under load until its separate fix lands. This PR will remain open until the v0.9.0 tag exists and independent review and hosted CI are complete.

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Building Building Preview Oct 16, 2026 4:13am UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 0e883dec Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant